Does not return valid file: URLs when handling absolute paths on windows

[ef4]

If we resolve an absolute path on windows, we get back a path that is not a valid file: URL:

import { resolve } from 'import-meta-resolve';
import { pathToFileURL } from 'url';

console.log(
  resolve(
    "C:\\Users",
    pathToFileURL("C:\\Users\\X\\")
  )
);

prints "c:\Users"
expected result: "file:///c/Users"

This is inconsistent with the behavior on posix:

import { resolve } from 'import-meta-resolve';
import { pathToFileURL } from 'url';

console.log(
  resolve(
    "/home",
    pathToFileURL("/home/x/")
  )
);

prints "file:///home"

I noticed this issue because Node will refuse to import() absolute paths on windows that are not valid file: URLs. If we're using resolve on user-provided paths and then import()ing them, it's reasonable for users to expect an absolute path to work.

[wooorm]

Hi! I don’t have windows to test with. And in your examples there is no comparison with import.meta.resolve that is in node, which this ports.

If we're using resolve on user-provided paths and then import()ing them, it's reasonable for users to expect an absolute path to work

Importantly, this project does not support paths. Not sure what you mean with this?

[ef4]

I checked the built-in node behavior and it matches this library, so I agree the bug is not here. It is arguably a node bug though and I will move over to there. (It seems bad if the output of import.meta.resolve is not accepted as input to import()).