Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in wc_get_product_id_by_global_unique_id #50702

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

nathanss
Copy link
Contributor

@nathanss nathanss commented Aug 15, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Fix typo in wc_get_product_id_by_global_unique_id

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Products > Add.
  2. Create a product with a GTIN, UPC, EAN, or ISBN value
  3. Publish it.
  4. Try to create another product with the same value.
  5. Check that you see the message 'Invalid or duplicated GTIN, UPC, EAN or ISBN.'.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 15, 2024
Copy link
Contributor

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Copy link
Contributor

@vedanshujain vedanshujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems to be working as expected, and method returns the product id with duplicate unique id.

Screenshot 2024-08-15 at 6 33 50 PM

@nathanss nathanss merged commit 1235f4d into trunk Aug 15, 2024
29 checks passed
@nathanss nathanss deleted the fix/correct-typo branch August 15, 2024 13:14
@github-actions github-actions bot added this to the 9.3.0 milestone Aug 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 15, 2024
@jorgeatorres jorgeatorres modified the milestones: 9.3.0, 9.2.0 Aug 15, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants