Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Firefox support for making Order Summary sticky when not longer than view #49744

Conversation

wavvves
Copy link
Contributor

@wavvves wavvves commented Jul 22, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Changes shipped on #47680 make use of computedStyleMap which is not supported in Firefox
This PR prevents the console errors and ads support for Firefox by using getComputedStyles.

Closes #49525

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. On Firefox add a product to the Cart
  2. Go to the Checkout Blocks page and open the inspector
  3. Verify the following error is not displayed in the JS console Uncaught TypeError: e.computedStyleMap is not a function...
  4. Reduce the window height so that it's smaller than the order summary.
  5. Try scrolling, the order summary should not be sticky.
  6. Collapse the items in order summary and expand the window height.
  7. Try scrolling now, the order summary should be sticky.

Verify everything still works on other supported browsers by following steps:

  1. Add some items to cart and go to Checkout.
  2. Reduce the window height so that it's smaller than the order summary.
  3. Try scrolling, the order summary should not be sticky.
  4. Collapse the items in order summary and expand the window height.
  5. Try scrolling now, the order summary should be sticky.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@wavvves wavvves added type: bug The issue is a confirmed bug. focus: checkout Issues related to checkout page. block: checkout Issues related to the checkout block. type: compatibility labels Jul 22, 2024
@wavvves wavvves requested a review from senadir July 22, 2024 00:34
@wavvves wavvves self-assigned this Jul 22, 2024
@wavvves wavvves linked an issue Jul 22, 2024 that may be closed by this pull request
5 tasks
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 22, 2024
Copy link
Contributor

github-actions bot commented Jul 22, 2024

Hi @senadir, @woocommerce/rubik

Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Jul 22, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Copy link
Contributor

Size Change: +39 B (0%)

Total Size: 2.3 MB

compressed-size-action

@wavvves wavvves requested a review from a team July 22, 2024 11:19
@wavvves wavvves added this to the 9.2.0 milestone Jul 22, 2024
@github-actions github-actions bot removed this from the 9.2.0 milestone Jul 22, 2024
Copy link
Member

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you!

@wavvves wavvves added this to the 9.2.0 milestone Jul 23, 2024
@github-actions github-actions bot removed this from the 9.2.0 milestone Jul 23, 2024
@wavvves wavvves merged commit 3d148e2 into trunk Jul 23, 2024
37 checks passed
@wavvves wavvves deleted the 49525-checkout-page-uncaught-typeerror-ecomputedstylemap-is-not-a-function branch July 23, 2024 14:38
@github-actions github-actions bot added this to the 9.2.0 milestone Jul 23, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jul 23, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 24, 2024
@ralucaStan ralucaStan added the team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: checkout Issues related to the checkout block. focus: checkout Issues related to checkout page. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: bug The issue is a confirmed bug. type: compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkout page Uncaught TypeError: e.computedStyleMap is not a function
4 participants