-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Firefox support for making Order Summary sticky when not longer than view #49744
Added Firefox support for making Order Summary sticky when not longer than view #49744
Conversation
Hi @senadir, @woocommerce/rubik Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Size Change: +39 B (0%) Total Size: 2.3 MB |
…putedstylemap-is-not-a-function
…putedstylemap-is-not-a-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, thank you!
Submission Review Guidelines:
Changes proposed in this Pull Request:
Changes shipped on #47680 make use of
computedStyleMap
which is not supported in FirefoxThis PR prevents the console errors and ads support for Firefox by using
getComputedStyles
.Closes #49525
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Uncaught TypeError: e.computedStyleMap is not a function...
Verify everything still works on other supported browsers by following steps:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment