Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky checkout coupons e2e test #48555

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

veljkho
Copy link
Contributor

@veljkho veljkho commented Jun 18, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #48554

Added wait to be hidden for the block overlay.
Tested 23 times locally and it worked, 23 x 3 tests.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. pnpm test:e2e-pw ./tests/e2e-pw/tests/shopper/cart-checkout-coupons.spec.js

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@veljkho veljkho self-assigned this Jun 18, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 18, 2024
@veljkho veljkho requested a review from a team June 18, 2024 13:00
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@adimoldovan adimoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veljkho!

@adimoldovan adimoldovan merged commit 72672ac into trunk Jun 18, 2024
20 checks passed
@adimoldovan adimoldovan deleted the e2e/fix/flaky-checkout-coupons-test branch June 18, 2024 14:14
@github-actions github-actions bot added this to the 9.1.0 milestone Jun 18, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jun 18, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jun 19, 2024
lanej0 pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky] shopper/cart-checkout-coupons.spec.js
3 participants