Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping Settings: Update Create btn text on method creation #44788

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

psealock
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

The "Create" button on the Shipping method modal creation screen has caused confusion because the merchant is sometimes not aware the action also saves. See pevPIe-hv#comment-341 for more info.

This PR changes the text to "Create and save".

image

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new Shipping Zone /wp-admin/admin.php?page=wc-settings&tab=shipping&zone_id=new
  2. Click "Add shipping method"
  3. Select any method and click "Continue"
  4. See the "Create and save button"

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Update Shipping Method creation call to action button with more clear label

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 20, 2024
@psealock psealock requested review from a team, ilyasfoo and rjchow February 20, 2024 03:23
Copy link
Contributor

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
Copy link
Contributor

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@psealock psealock changed the title Update shipping method btn text on create Shipping Settings: Update Create btn text on method creation Feb 20, 2024
Copy link
Contributor

github-actions bot commented Feb 20, 2024

Test Results Summary

Commit SHA: c110afa

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests33700303409m 10s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy 😄

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛍️

@ilyasfoo
Copy link
Contributor

That was supposed to be a 🚢

@psealock psealock closed this Feb 20, 2024
@psealock psealock reopened this Feb 20, 2024
@psealock psealock enabled auto-merge (squash) February 20, 2024 21:33
@psealock psealock merged commit 487f230 into trunk Feb 20, 2024
39 checks passed
@psealock psealock deleted the update/save-shipping-method-create-btn branch February 20, 2024 21:46
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 20, 2024
@alvarothomas alvarothomas added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants