Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Save draft" instead of "Saved" on initial product page #38609

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Jun 5, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Previously, the "Saved" button was shown indicating a new product had already been saved prior to saving. This PR shows "Save draft" instead for new products.

Before

Screen Shot 2023-06-05 at 9 43 40 AM

After

Screen Shot 2023-06-05 at 9 42 52 AM

Closes #38608 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the product blocks editor under WooCommerce->Settings->Advanced->Features.
  2. Navigate to WooCommerce -> Add product.
  3. Note that the button in the top right initially says "Save draft"
  4. Make some changes and save the product
  5. Note that the button now says "Saved"

@joshuatf joshuatf requested a review from a team June 5, 2023 16:48
@joshuatf joshuatf self-assigned this Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Test Results Summary

Commit SHA: 607324d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests1950010020514m 50s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@joshuatf
Copy link
Contributor Author

joshuatf commented Jun 8, 2023

Hey @mattsherman 👋 had to give this a rebase to get some flakey tests passing. Could you give this another ✅ ?

Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM! :shipit:

@mattsherman
Copy link
Contributor

Hey @mattsherman 👋 had to give this a rebase to get some flakey tests passing. Could you give this another ✅ ?

You actually don't have to get another approval anymore. But, I gave it a quick spin and made sure you didn't sneak anything in! 😉

@joshuatf joshuatf merged commit e09e8b8 into trunk Jun 8, 2023
@joshuatf joshuatf deleted the fix/38608 branch June 8, 2023 22:32
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Block Editor: New product form shows as "Saved" immediately
2 participants