Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the readme link to Facebook WC group #34150

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Update the readme link to Facebook WC group #34150

merged 1 commit into from
Aug 2, 2022

Conversation

roykho
Copy link
Member

@roykho roykho commented Aug 1, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #33884

How to test the changes in this Pull Request:

  1. Go to https://github.com/woocommerce/woocommerce/blob/update/readme/README.md
  2. Ensure you can see the newly added Facebook link with updated title to match the name on Facebook.
  3. Clicking on the link should take you to the Facebook page.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@roykho roykho requested review from a team and samueljseay and removed request for a team August 1, 2022 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Test Results Summary

Commit SHA: 76df016

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 38s
E2E Tests185001018612m 55s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@samueljseay samueljseay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 🚀

@roykho roykho merged commit 0f3dc18 into trunk Aug 2, 2022
@roykho roykho deleted the update/readme branch August 2, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo README.md references non-existing Facebook group for support
2 participants