[Analytics Hub] Handle range selection granularity and interval #8341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the SelectionType interval
Collaborator
You can test the changes from this Pull Request by:
|
ealeksandrov
approved these changes
Dec 8, 2022
Contributor
ealeksandrov
left a comment
ealeksandrov
left a comment
There was a problem hiding this comment.
LGTM with one small improvement suggestion! 
| case .monthToDate, .lastMonth: | ||
| return 31 | ||
| case .quarterToDate, .lastQuarter: | ||
| return 12 |
Contributor
There was a problem hiding this comment.
For amount of weeks in a quarter should we pick 13 to be more precise?
Year is 52 weeks (+1-2 days), so 52+/4 = 13+
Contributor
Author
There was a problem hiding this comment.
Makes perfect sense! Thanks! Fixed here: 1ca89c2
| } | ||
| } | ||
|
|
||
| /// The resopnse interval size that should be used to request stats from the given SelectedType |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| /// The resopnse interval size that should be used to request stats from the given SelectedType | |
| /// The response interval size that should be used to request stats from the given SelectedType |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8189
Why
The stats request are currently using a fixed granularity of days with an interval size of
31. For better request performance and a correct chart render, we need to use the correct granularity and interval based on the selected time range.How
Adds to the
SelectedTypetwo computed properties:granularityandintervalSize, grouping the response based on the time range nature likedays,weeks,months,quartersandyears.How to Test
Update release notes:
RELEASE-NOTES.txtif necessary.