Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Nov 25, 2022

Part of #8075

Description

This PR update UI for the screens in the native Jetpack setup flow following the latest updates [p1669336075073439-slack-C046HDZL87J]. Changes include:

  • Error screens: Changed copies and added site address information.
  • Site credentials login screen: Updated the text field style, updated the title, and removed the disclaimer about approval.
  • Jetpack setup screen:
    • Display the "Error" text underneath any step that fails
    • Removed the “Approval required” warning from the connection step.
    • Changed the “Authorising” step name – in the step list and the web view.
    • Changed the “Connection approved” status to just “Connected”.
  • Empty store picker: updated assets for both light and dark modes.

Testing instructions

Prerequisite: make sure that you have a test site without Jetpack.

  • Log out of the app or skip login onboarding if needed.
  • On the prologue screen, select "Log In" or "Continue with WordPress.com" based on the A/B test variant you get.
  • Log in with your WordPress.com account.
  • If your account is not associated with any site, notice that the empty store picker has the correct image for both dark and light modes.
  • On the store picker, select Add a Store > Connect an existing site.
  • Enter the address of your test store and tap Continue.
  • On the Jetpack error screen, notice that the UI is updated correctly. Select Install Jetpack or Connect Jetpack.
  • When the site credential login screen is presented, notice the UI is updated correctly.
  • Enter the correct credentials for a shop manager or administrator account.
  • On the Jetpack setup screen, when the setup reaches the connection step, notice that a web view is presented for approving the Jetpack connection. The UI and copies for both screen should be correct.
  • Tap Cancel to dismiss the web view, notice that a new view is presented regarding the interrupted Jetpack connection with the updated design.

Screenshots

Empty store picker:

Light mode Dark mode

Error screens:

Jetpack setup Jetpack connection Setup interrupted

Site credential screen:

Setup flow:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-11-25.at.15.19.41.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: login Related to any part of the log in or sign in flow, or authentication. labels Nov 25, 2022
@itsmeichigo itsmeichigo added this to the 11.4 milestone Nov 25, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 25, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8217-2b0db77 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from issue/8075-native-jetpack-install to trunk November 25, 2022 04:19
@itsmeichigo itsmeichigo marked this pull request as ready for review November 25, 2022 08:24
@selanthiraiyan selanthiraiyan self-assigned this Nov 25, 2022
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

itsmeichigo and others added 2 commits November 25, 2022 17:56
Co-authored-by: Sharma Elanthiraiyan <sharma.elanthiraiyan@automattic.com>
@itsmeichigo itsmeichigo merged commit 80661f9 into trunk Nov 25, 2022
@itsmeichigo itsmeichigo deleted the issue/8075-ui-updates branch November 25, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants