[Analytics Hub] Add formatters for net revenue stats data #8207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
You can test the changes from this Pull Request by:
|
Ecarrion
approved these changes
Nov 24, 2022
|
|
||
| // If revenue is an integer, no decimal points are shown. | ||
| let numberOfDecimals: Int? = revenue.isInteger ? 0 : nil | ||
| let currencyFormatter = currencyFormatter ?? CurrencyFormatter(currencySettings: ServiceLocator.currencySettings) |
Contributor
There was a problem hiding this comment.
nit: you can set the formatter as a default parameter to make the code a bit clean.
ealeksandrov
approved these changes
Nov 24, 2022
|
|
||
| // If revenue is an integer, no decimal points are shown. | ||
| let numberOfDecimals: Int? = revenue.isInteger ? 0 : nil | ||
| let currencyFormatter = currencyFormatter ?? CurrencyFormatter(currencySettings: ServiceLocator.currencySettings) |
Contributor
There was a problem hiding this comment.
nit: I feel this is more readable when we declare default value near the non-optional func parameter.
Now passing nil means using default value, but it is not obvious from outside of the function.
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8150
Description
This PR adds methods to retrieve and format the net revenue value and delta used for the "Net Sales" column on the Revenue Analytics card:
Testing
These methods aren't yet used in the app; confirm the unit tests are checking the correct values and tests pass.
Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.