Skip to content

Analytics Hub: Adjust UI for landscape orientation #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

Analytics Hub: Adjust UI for landscape orientation #8197

merged 1 commit into from
Nov 24, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Nov 23, 2022

closes #8148

Why

This PR makes sure the Analytics Hub Main View looks good in landscape orientation.

Portrait landscape Big Fonts
normal lanscape Accessibility
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the feature: hub menu Related to the Hub Menu tab. label Nov 23, 2022
@Ecarrion Ecarrion added this to the 11.4 milestone Nov 23, 2022
@Ecarrion Ecarrion self-assigned this Nov 23, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 23, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@Ecarrion Ecarrion changed the title Products Onboarding: Adjust UI for landscape orientation Analytics Hub: Adjust UI for landscape orientation Nov 23, 2022
@rachelmcr rachelmcr self-assigned this Nov 24, 2022
rachelmcr
rachelmcr approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@Ecarrion Ecarrion enabled auto-merge November 24, 2022 13:27
@Ecarrion Ecarrion force-pushed the issue/8148-accessibility branch from 86c86ad to 28241b7 Compare November 24, 2022 18:51
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 24, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8197-28241b7 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion merged commit 026e9da into trunk Nov 24, 2022
@Ecarrion Ecarrion deleted the issue/8148-accessibility branch November 24, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ecarrion Ecarrion

@rachelmcr rachelmcr

Labels

feature: hub menu Related to the Hub Menu tab.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Create reusable Analytics stats main body with info card component

4 participants

@Ecarrion @wpmobilebot @rachelmcr