Merge 11.0 final to trunk #8025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
added
the
Releases
Generated by 🚫 dangerJS |
Collaborator
You can test the changes from this Pull Request by:
|
AliSoftware
approved these changes
Nov 4, 2022
Contributor
There was a problem hiding this comment.
Approving on principle to unblock as the PR diff looks ok to me.
As for the Unit Tests failing:
- I have no clue as to why those 6 tests are failing on CI
- While they'll need to be fixed at some point, their failure shouldn't be related to the changes from this PR, so better not block the finalization and next code freeze and ask the team to fix them separately.
- I've ran the Unit Tests in Xcode 14 on my Mac and they passed anyway
Update: Sergiy informed the #mobile-woo-payments team about those tests' flakiness here in Slack: p1667565530274009-slack-C025A8VV728
Contributor
Author
|
Thank you @AliSoftware! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to finalize the release a couple extra times. First it was due to an incorrect GlotPress translation which I've fixed at the source (it was a straightforward fix) and the second one was due to my GitHub token being expired. We have treated the extra version bump as a harmless commit in the past, so I didn't fiddle with the release scenario to keep things simple.
The unit tests are consistently failing. It looks like they passed just fine in the code freeze PR, and none of the finalization changes should result in a unit test failure. So, I am wondering if this could be about any VM work that has been going on. cc @crazytonyli @mokagio
We'll need this PR to be merged today so we can do the next code freeze. So, even though there is a failure, I am marking this PR as ready for review.