Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

Closes WOOMOB-1602

Description

This PR adds a small update to the header of the booking details screen to keep product and customer names in 2 separate lines.

Test Steps

  1. Log in to a CIAB store with existing bookings.
  2. Select a booking with associated order.
  3. Confirm in the header that the product name and customer name are in separate lines.

Screenshots

Before After
Screenshot 2025-11-07 at 11 34 57 Screenshot 2025-11-07 at 11 37 50

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo marked this pull request as ready for review November 7, 2025 04:41
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Nov 7, 2025
@itsmeichigo itsmeichigo added this to the 23.7 milestone Nov 7, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 7, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16324-d5c7f92
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commitd5c7f92
Installation URL5gpjt340k8s3g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas self-assigned this Nov 7, 2025
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d just be cautious about joining the two strings with \n — that approach turns them into a single text block, which can cause issues later on with dynamic type, truncation.

I’d recommend rendering them as two separate Text views inside a VStack instead. That gives us better layout flexibility.

Also the the current spacing in the header seems to be off compared to the design of i2.

Image

The spacing is also 2 above "Women's Haircut" i just could not take the sceenshot with that.

@itsmeichigo
Copy link
Contributor Author

@AdamGrzybkowski Good observation! I separated the labels as suggested in d5c7f92 - this PR is ready for another look 🙏

@itsmeichigo itsmeichigo requested a review from adborbas November 7, 2025 09:04
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants