Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Nov 5, 2025

Closes (WOOMOB-1611)[https://linear.app/a8c/issue/WOOMOB-1611]

Description

Fixes the linked issue by reusing the ProductSelectorNavigationView, which wraps the selector in a NavigationStack. Interestingly, the problem was sporadic, which I did not notice when I opened the ticket, and even more interestingly, it failed more often in the simulator than on the device. Either way, using the navigation stack, the issue is fixed; it just took me way too long to find the fix.

Test Steps

  1. Start the app.
  2. Open the order tab.
  3. Tap the "+" icon in the nav bar.
  4. Tap on "+ Add Products".
  5. Tap on the product with variations.
  6. Select a variation.
  7. Note that you are NOT navigated back to the "Select products" screen.
  8. Note that the variation is marked as selected.
  9. Tap back.
  10. Note that you see the product marked as selected.

Screenshots

Before After
ScreenRecording_10-30-2025 09-09-00_1 (1) ScreenRecording_11-05-2025 14-01-15_1

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas added this to the 23.7 milestone Nov 5, 2025
@adborbas adborbas added the type: bug A confirmed bug. label Nov 5, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 5, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16317-9b7759c
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commit9b7759c
Installation URL72d6stc2hrhu0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas changed the title Trigger selection change on dismiss Fix product variation selection for order creation Nov 5, 2025
@adborbas adborbas marked this pull request as ready for review November 5, 2025 13:03
@adborbas adborbas requested a review from itsmeichigo November 6, 2025 07:41
@itsmeichigo itsmeichigo self-assigned this Nov 7, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@adborbas adborbas enabled auto-merge November 7, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants