Improve dynamic size of shipment details bottom sheet #15648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelKayumov
force-pushed
the
WOOMOB-476-fix-shipping-labels-dynamic-layout
branch
from
470a467 to
9adb76c
Compare
Collaborator
|
|
RafaelKayumov
force-pushed
the
WOOMOB-476-fix-shipping-labels-dynamic-layout
branch
from
9adb76c to
12813d1
Compare
itsmeichigo
approved these changes
May 19, 2025
Contributor
itsmeichigo
left a comment
itsmeichigo
left a comment
There was a problem hiding this comment.
Thanks for the fix! Tested and confirmed using simulator iPhone 16 Pro with accessibility font sizes.
| .footnoteStyle() | ||
| } | ||
| AdaptiveStack { | ||
| HStack { |
Contributor
There was a problem hiding this comment.
Nit: setting top alignment would make the layout look nicer in this case:
| .frame(idealHeight: Layout.rowHeight) | ||
| ForEach(viewModel.shippingLines) { shippingLine in | ||
| AdaptiveStack { | ||
| HStack { |
Contributor
There was a problem hiding this comment.
Same suggestion as above about the child item alignment.
|
|
||
| static let toggleTextLineLimit = 3 | ||
| static let toggleTextMaxDynamicTypeSizePortrait = DynamicTypeSize.accessibility1 | ||
| static let toggleTextMaxDynamicTypeSizeAlbum = DynamicTypeSize.xxxLarge |
Contributor
There was a problem hiding this comment.
Super nit: can we use landscape wording instead of album? I'm unfamiliar with this wording, which may be hard to understand.
Comment on lines
+167
to
+175
| .onChange(of: geometry.size) { newSize in | ||
| /// Support dynamic type size change | ||
| if index < tabWidths.count { | ||
| tabWidths[index] = newSize.width | ||
| if index == selectedTab { | ||
| underlineTabWith(tabGeometry: geometry) | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: WOOMOB-476
Description
The change in this PR fixes overlapping and shifting layout after applying a larger dynamic-type size.
.frame(idealHeight: Layout.rowHeight)fromWooShippingCreateLabelsViewAdaptiveStackwithHStack. Adaptive stack flips into a vertical stack when there is not enough width (widths becomes compact) making inline components to re-arrange vertically even if there is still some space available.Steps to reproduce
Testing information
Before - Album
Horizontal_Broken.mp4
After - Album
Horizontal_Fixed.mp4
Before - Portrait
Simulator.Screen.Recording.-.iPhone.16.-.2025-05-16.at.14.00.21.mp4
After - Portrait
Simulator.Screen.Recording.-.iPhone.16.-.2025-05-16.at.13.57.25.mp4
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: