Fix crash on order details when sections are updated

[itsmeichigo]

Closes WOOMOB-482

Description

This PR fixes a crash when the order details screen cannot reload after its sections are updated. Steps to reproduce:

1. Open a completed order on the app.
2. On the web, refund the same order
3. On the app, pull to refresh the screen. The app would crash when rendering a row that no longer exists (e.g. shipping label related row if the app has Woo Shipping or WCS&T plugin set up).

The crash was due to a check for isViewLoaded and the table view reloading is skipped if the view is not yet loaded into memory. This check is from a legacy commit from long ago that is now redundant. Removing the check enables the table to load properly when needed.

Testing instructions

1. Open a completed order on the app.
2. On the web, refund the same order
3. On the app, pull to refresh the screen. Confirm that the app does not crash.

Testing information

Tested following the steps above on simulator iPhone 16 Pro iOS 18.2 and confirmed that the app no longer crashes.

Also did some smoke testing on the order details screen and confirmed that the screen loads correctly for orders of different statuses.

Screenshots

Screen.Recording.2025-05-14.at.15.52.28.mov

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 22.4. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[itsmeichigo]

This is redundant as the reloadSections method in the datasource already triggers a reload.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	29838
	Version	PR #15633
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	de6f3fe
	Installation URL	47uc4tjd434a8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[jaclync]

Crash that I could repro after a full refund on web in trunk no longer happens now thanks for fixing this!

Just wondering, since this isViewLoaded check has been around since 2018, do we know what might have changed that causes this likely recent crash? Like some new calls when isViewLoaded == true?

[jaclync]

Sidenote: my test site doesn't have any shipping plugins, just WooCommerce.

[itsmeichigo]

Thanks @jaclync for the review!

do we know what might have changed that causes this likely recent crash? Like some new calls when isViewLoaded == true

With many moving pieces on the order details screen over the years, I have no good answer to this. My wild guess is that the introduction of the split view might have something to do with this, as there have been significant changes to the hierarchy of the Orders tab. But I'm not 100% sure - we would need to test again with a pre-split view build to confirm that.

Sidenote: my test site doesn't have any shipping plugins, just WooCommerce.

My understanding is that the order item section goes through the most changes when an order status is changed to refunded, so that could possibly be a reason for the crash when reloading the table view.

I'm merging the PR for now.