-
Notifications
You must be signed in to change notification settings - Fork 120
[Woo POS] Cancel payment after leaving POS #15205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
e9afb3d to
4a24a70
Compare
4a24a70 to
7420830
Compare
staskus
commented
Feb 19, 2025
|
|
||
| @MainActor | ||
| func cancelPayment() async throws { | ||
| let cancelPaymentTask: () -> Void = cancelPayment |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot call cancelPayment here without confusing the compiler
joshheald
approved these changes
Feb 20, 2025
4 tasks
Base automatically changed from
issue/15180-mitigate-payment-issues-caused-by-pos-memory-leaks
to
trunk
February 20, 2025 14:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15181
Merge after: #15207
Description
Cancel payment after leaving POS.
With these changes, memory leaks continue for me when exiting POS while in "Tap/Swipe/Insert" state. I noticed that in this instance
CardPresentPaymentCollectOrderPaymentUseCaseAdaptortask cancelation and continuation are not called. I wonder if it could be a reason for the leaks, since ifwithCheckedThrowingContinuationis not resumed, the Task continues. Just one of the ideas.Steps to reproduce
Testing information
Tested with iPad Pro 11 inch iOS 18.2 simulator.
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: