-
Notifications
You must be signed in to change notification settings - Fork 215
Add test coverage for update_or_create_customer with order parameter #4844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Copilot
wants to merge
2
commits into
fix/832-exclude-order-parameter-when-creating-stripe-customers
from
copilot/sub-pr-4841
Closed
Add test coverage for update_or_create_customer with order parameter #4844
Copilot
wants to merge
2
commits into
fix/832-exclude-order-parameter-when-creating-stripe-customers
from
copilot/sub-pr-4841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Co-authored-by: diegocurbelo <407542+diegocurbelo@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on excluding order parameter in Stripe requests
Add test coverage for update_or_create_customer with order parameter
Dec 3, 2025
Copilot finished work on behalf of
diegocurbelo
December 3, 2025 22:07
Member
|
Closed in favor of 314951b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes feedback from #4841 regarding missing test coverage for the
update_or_create_customer()call with the order parameter inget_customer_id_for_order().Changes proposed in this Pull Request:
Adds test coverage for
update_or_create_customer()when called with an order object to retrieve billing details:test_update_or_create_customer_retrieves_billing_details_from_order()- Verifies all billing fields (email, name, address, city, state, postcode, country) are correctly retrieved from the order and included in the Stripe customer creation requesttest_update_or_create_customer_with_pay_for_order_context()- VerifiesCUSTOMER_CONTEXT_PAY_FOR_ORDERcontext works with minimal details (email only)Both tests mock
WC_Orderand Stripe API endpoints to verify request payloads without actual API calls.Testing instructions
These are unit tests that will run as part of the PHPUnit test suite. No manual testing required.
npm run test:php -- --filter "WC_Stripe_Customer_Test"Changelog entry
Changelog Entry Comment
Comment
Test-only changes, no user-facing functionality affected.
Post merge
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.