Skip to content

Add support for multiple subscriptions #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

Add support for multiple subscriptions #295

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6297864
Update class-wc-gateway-payfast.php
ryanr14 Apr 22, 2025
e8a32e0
Update changelog.txt
ryanr14 Apr 22, 2025
8af843b
Update woocommerce-gateway-payfast.php
ryanr14 Apr 22, 2025
d54defc
Delete changelog.txt
ryanr14 May 7, 2025
acdc088
Delete woocommerce-gateway-payfast.php
ryanr14 May 7, 2025
f6245bd
Updating files in my pull request to remove unneeded changes. No need…
ryanr14 May 8, 2025
c494c05
Update changelog.txt
ryanr14 May 8, 2025
c7590ff
Update woocommerce-gateway-payfast.php
ryanr14 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions includes/class-wc-gateway-payfast.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public function __construct() {
'subscription_date_changes',
'subscription_payment_method_change', // Subs 1.x support.
'subscription_payment_method_change_customer', // Enabled for https://github.com/woocommerce/woocommerce-gateway-payfast/issues/32.
'multiple_subscriptions',
Copy link
Collaborator

@dkotter dkotter May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested things but are there no specific updates needed to support multiple subscriptions, things just work as long as we declare support?

Copy link
Author

@ryanr14 ryanr14 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is my understanding based on this doc section here, "Step 1.1: Registering Support for Subscription Management Features"

Copy link
Collaborator

@dkotter dkotter May 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading that section, it shows how to declare support in your extension for each of those subscription features. But we need to be sure multiple subscriptions actually work before we can declare that compatibility. Has testing been done to verify multiple subscriptions works here?

);

$this->init_form_fields();
Expand Down