This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use navigate function inside filter blocks
#8524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/interactivity/directives.js
assets/js/utils/filters.ts |
|
Size Change: +2.15 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
DAreRodz
removed
the
status: stale
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
|
Closing this as per #8456 (comment). To follow current work on improving the Filter blocks, check out woocommerce/woocommerce#42255. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use
navigatefrom@woocommerce/interactivityin filter blocks so they update only the HTML that changes, instead of doing a full HTML reload.Tracking issue: woocommerce/woocommerce#42486
Will close #8456
Why
To gradually adopt the Interactivity API, without having to reimplement current blocks.
How
TBD