Fix crash when logging in with site address

[JorgeMucientes]

Fixes: #8056

Description

Fixes crash when trying to log in using their site address if the site address contains suffixes like wp-admin or wp-login.php

Testing instructions

Log into the app using site address with wp-admin suffix and check that the app doesn't crash.

Images/gif

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

[codecov-commenter]

Codecov Report

Base: 43.02% // Head: 43.02% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (9c519dc) compared to base (2f9b61b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk    #8083      +/-   ##
============================================
- Coverage     43.02%   43.02%   -0.01%     
  Complexity     3522     3522              
============================================
  Files           679      679              
  Lines         36956    36958       +2     
  Branches       4790     4790              
============================================
  Hits          15901    15901              
- Misses        19629    19631       +2     
  Partials       1426     1426              

Impacted Files	Coverage Δ
.../sitediscovery/SitePickerSiteDiscoveryViewModel.kt	0.00% <0.00%> (ø)
...in/kotlin/com/woocommerce/android/util/UrlUtils.kt	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hichamboushaba]

Just a np, this extension will be suggested in the autocomplete for all of the String instances, this is not a blocker, but without context, it's not clear what it does. Before, it was a private extension inside the class SitePickerSiteDiscoveryViewModel, so it was clear what it was about.
WDYT about moving it inside UrlUtils? we can then keep it as an extension and call it by providing the context receiver: with(urlUtils) { url.sanitiseUrl() }, or make it a regular function.

[JorgeMucientes]

Good point @hichamboushaba . I've moved it inside UrlUtils to make it clear “sanitizing” should only be applied to URLs.

[hichamboushaba]

Works well, thanks for taking care of this @JorgeMucientes 👍.

I left a comment above, but it's not a blocker, feel free to merge if you want 🙂.

[hichamboushaba]

Thanks for making the changes @JorgeMucientes 💯