Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS][Non-Simple Products] Font and Color changes to Items and Cart screens #13382

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

AnirudhBhat
Copy link
Contributor

@AnirudhBhat AnirudhBhat commented Jan 23, 2025

Closes: #13381

Description

This PR makes minor UI changes to Items and Cart screens:

  1. Change text style and font weight for Item name
  2. Change text color for item price
  3. Change font weight of Cart item name
  4. Change height of Cart card
  5. Allow max of 2 lines for variation names in cart
  6. Change text color of variation name in cart

Design: rNAclWFAdQRw7EXEcsNVai-fi-2662_8765

Steps to reproduce

Navigate to POS (More menu -> POS) and ensure the Item (including variation screen) and the Cart screen design looks as per Figma design in both Light and Dark mode

Images/gif

design_change_dark
design_change_light

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: task An internally driven task. category: design Layout and style elements in the UI or user interface, including color and animations. feature: point of sale POS project labels Jan 23, 2025
@AnirudhBhat AnirudhBhat added this to the 21.5 milestone Jan 23, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite44db3d
Direct Downloadwoocommerce-wear-prototype-build-pr13382-e44db3d.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite44db3d
Direct Downloadwoocommerce-prototype-build-pr13382-e44db3d.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (cdcdbdc) to head (e44db3d).
Report is 7 commits behind head on trunk.

Files with missing lines Patch % Lines
...ce/android/ui/woopos/home/items/WooPosItemsList.kt 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13382      +/-   ##
============================================
- Coverage     41.10%   41.09%   -0.01%     
+ Complexity     6482     6481       -1     
============================================
  Files          1325     1325              
  Lines         77555    77558       +3     
  Branches      10687    10687              
============================================
- Hits          31879    31876       -3     
- Misses        42845    42850       +5     
- Partials       2831     2832       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. feature: point of sale POS project type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS][Non-Simple Products] UI font and color changes in Item and Cart screens
4 participants