Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update origin address endpoint #13297

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Jan 14, 2025

Part of: #12437

Description

This PR updates the get origin addresses endpoint to use the address/origins route, not the deprecated origin-addresses.

More context p1735753074739799/1734441247.830119-slack-C05VBLKHHV1

Testing information

Make sure CI passes

The tests that have been performed

Check that the endpoint retrieves the expected information

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 14, 2025
@atorresveiga atorresveiga added this to the 21.5 milestone Jan 14, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 14, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit79b512a
Direct Downloadwoocommerce-wear-prototype-build-pr13297-79b512a.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 14, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit79b512a
Direct Downloadwoocommerce-prototype-build-pr13297-79b512a.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.10%. Comparing base (069f146) to head (79b512a).
Report is 4 commits behind head on trunk.

Files with missing lines Patch % Lines
...inglabels/networking/WooShippingLabelRestClient.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13297   +/-   ##
=========================================
  Coverage     41.10%   41.10%           
  Complexity     6421     6421           
=========================================
  Files          1321     1321           
  Lines         77177    77177           
  Branches      10643    10643           
=========================================
  Hits          31722    31722           
  Misses        42646    42646           
  Partials       2809     2809           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit 3222339 into trunk Jan 14, 2025
15 checks passed
@atorresveiga atorresveiga deleted the issue/12437-update-origin-address-endpoint branch January 14, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants