Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update illustrated icons #13241

Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 4, 2025

Closes: woocommerce/woomobile-private#402

Description

This updates two icons from Illustrated Icons file (eyHme0rFactvLQlejGIFWT-fi-2950_14256)

Steps to reproduce

Bell icon

  1. Log in to a site that has Payments enabled.
  2. Go to Menu → Payments → Collect Payment

Timer icon

  1. Log in to a site eligible for creating Blaze campaigns.
  2. Create a campaign.
  3. At the final step, after entering credit card details, you will see the timer icon on the loading screen.
  4. Don't forget to cancel the created campaign.

The tests that have been performed

Steps above

Images/gif

Before After After dark
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 4, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit89c46e8
Direct Downloadwoocommerce-wear-prototype-build-pr13241-89c46e8.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit89c46e8
Direct Downloadwoocommerce-prototype-build-pr13241-89c46e8.apk

@irfano irfano changed the title Feature/update illustrated icons Update illustrated icons Jan 4, 2025
@hafizrahman hafizrahman self-assigned this Jan 6, 2025
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏼

@hafizrahman hafizrahman merged commit d2c86ad into feature/woo-2.0-brand-updates Jan 6, 2025
17 checks passed
@hafizrahman hafizrahman deleted the feature/update-illustrated-icons branch January 6, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants