Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tap card illustration #13238

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 4, 2025

Part of: woocommerce/woomobile-private#378

Description

This updates the tap card illustration colors. The original request: #13204 (comment)

Steps to reproduce

  1. Perform a clean install.
  2. Login with a site eligible to use Payments. (Internal guide: PdfdoF-D-p2)
  3. Enable Simulated Card Reader from "Menu → Settings → Developer Options"
  4. Go to "Menu → Payments → Collect Payment", enter an amount, and select "Card reader" on the payment method screen.
  5. Connect a reader.

The tests that have been performed

Steps in "Steps to reproduce"

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 4, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf57ca83
Direct Downloadwoocommerce-wear-prototype-build-pr13238-f57ca83.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf57ca83
Direct Downloadwoocommerce-prototype-build-pr13238-f57ca83.apk

WooCommerce/src/main/res/drawable/img_wc_ship_card_insert.xml Dismissed Show dismissed Hide dismissed
WooCommerce/src/main/res/drawable/img_wc_ship_card_insert.xml Dismissed Show dismissed Hide dismissed
WooCommerce/src/main/res/drawable/img_wc_ship_card_insert.xml Dismissed Show dismissed Hide dismissed
WooCommerce/src/main/res/drawable/img_wc_ship_card_insert.xml Dismissed Show dismissed Hide dismissed
WooCommerce/src/main/res/drawable/img_wc_ship_card_insert.xml Dismissed Show dismissed Hide dismissed
@hafizrahman hafizrahman self-assigned this Jan 6, 2025
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the update 👍🏼

@hafizrahman hafizrahman merged commit d419133 into feature/woo-2.0-brand-updates Jan 6, 2025
16 checks passed
@hafizrahman hafizrahman deleted the feature/update-tap-card-illustration branch January 6, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants