Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bulk Update Orders] Tracks #13216

Merged
merged 8 commits into from
Jan 3, 2025
Merged

[Bulk Update Orders] Tracks #13216

merged 8 commits into from
Jan 3, 2025

Conversation

hafizrahman
Copy link
Contributor

@hafizrahman hafizrahman commented Dec 30, 2024

Closes: #13215

Description

This implements the tracking as planned in pe5sF9-3xm-p2

Steps to reproduce

TC1: Success

  1. Start app and go to Orders, long press an Order to start the functionality. Ensure orders_list_bulk_update_selection_enabled is tracked
  2. Go to triple dot menu and select "Update Status". Ensure "orders_list_bulk_update_requested" is tracked, with property "status" and number of selected orders tracked.
  3. Select a status to update to, then tap OK. Ensure "orders_list_bulk_update_confirmed" is tracked, with property "status" and number of selected orders tracked.
  4. Wait for update success and ensure "orders_list_bulk_update_success" is tracked.

TC2: Failure

  1. Follow step 1 to 2 on TC1 above
  2. Turn off internet,
  3. Select a status to update to, then tap OK. Ensure "orders_list_bulk_update_failure" is tracked.

The tests that have been performed

I have tested the above.

Images/gif

n/a

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@hafizrahman hafizrahman changed the base branch from trunk to task/13140-connect-bulk-update-func December 30, 2024 03:48
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 30, 2024

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 30, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit45f444d
Direct Downloadwoocommerce-wear-prototype-build-pr13216-45f444d.apk

@hafizrahman hafizrahman added feature: analytics In-app store analytics feature: order details Related to order details. labels Dec 30, 2024
@hafizrahman hafizrahman added this to the 21.4 milestone Dec 30, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 30, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit45f444d
Direct Downloadwoocommerce-prototype-build-pr13216-45f444d.apk

@hafizrahman hafizrahman added the category: tracks Related to analytics, including Tracks Events. label Dec 30, 2024
@hafizrahman hafizrahman marked this pull request as ready for review December 30, 2024 04:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (22e1f7f) to head (45f444d).
Report is 20 commits behind head on trunk.

Files with missing lines Patch % Lines
...merce/android/ui/orders/list/OrderListViewModel.kt 0.00% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13216      +/-   ##
============================================
- Coverage     40.61%   40.60%   -0.01%     
  Complexity     6386     6386              
============================================
  Files          1351     1351              
  Lines         77506    77534      +28     
  Branches      10661    10661              
============================================
+ Hits          31480    31485       +5     
- Misses        43246    43269      +23     
  Partials       2780     2780              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JorgeMucientes JorgeMucientes self-assigned this Dec 31, 2024
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, code looks good and works as expected 👍🏼

@hafizrahman
Copy link
Contributor Author

Thanks @JorgeMucientes , I'll merge this once target is trunk

@hafizrahman hafizrahman added status: do not merge Dependent on another PR, ready for review but not ready for merge. feature: order list Related to the order list. and removed feature: order details Related to order details. labels Jan 3, 2025
Base automatically changed from task/13140-connect-bulk-update-func to trunk January 3, 2025 09:33
@hafizrahman hafizrahman removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jan 3, 2025
@hafizrahman hafizrahman enabled auto-merge January 3, 2025 11:04
@hafizrahman hafizrahman merged commit 9153b1d into trunk Jan 3, 2025
15 checks passed
@hafizrahman hafizrahman deleted the task/13215-bulk-order-tracks branch January 3, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: analytics In-app store analytics feature: order list Related to the order list.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Track events
5 participants