Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove configure wrapping tasks #12934

Merged
merged 1 commit into from
Nov 19, 2024
Merged

RFC: Remove configure wrapping tasks #12934

merged 1 commit into from
Nov 19, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Nov 15, 2024

Description

This PR removes wrapper around configure tool, used for applying and updating secret properties in the app.

My arguments to remove these tasks are following

  • these don't seem to be that useful: calling fastlane action is convenient, has a step-by-step guide and gives more customization like backing up files etc.
  • tasks support only half of the usecases: applying secrets. To update secrets, one has to still call fastlane directly
  • other projects (both Android and iOS) don't use any wrappers and don't report any issues with calling fastlane directly
  • these tasks are not configuration-cache compatible (it'd be possible to adjust them, though)

Tasks provide some improvements though like disabling fastlane's update check. But I think they're not that useful to keep them.

Removing these tasks clear the configuration code (less tasks to maintain) and unblocks further progress on enabling configuration cache.

Internal discussion: p1731673374633309-slack-CGPNUU63E

They have been recently removed from WordPress-Android repository: wordpress-mobile/WordPress-Android#21443

Load secrets by running `bundle exec fastlane run configure_apply` instead
@wzieba wzieba added the Core label Nov 15, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit65aa32d
Direct Downloadwoocommerce-wear-prototype-build-pr12934-65aa32d.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit65aa32d
Direct Downloadwoocommerce-prototype-build-pr12934-65aa32d.apk

@wzieba wzieba mentioned this pull request Nov 15, 2024
1 task
@AliSoftware
Copy link
Contributor

👍

@wzieba wzieba added this to the 21.2 milestone Nov 19, 2024
@wzieba wzieba marked this pull request as ready for review November 19, 2024 09:35
@wzieba wzieba requested a review from ParaskP7 November 19, 2024 09:38
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @wzieba !

I have reviewed (and tested) this PR as per the instructions, everything works as expected, thanks for this clean-up, the root level build.gradle file never looked that clean! 🪣

@wzieba wzieba merged commit 9a83bcc into trunk Nov 19, 2024
20 checks passed
@wzieba wzieba deleted the remove_configure_wrapper branch November 19, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants