Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update secrets to disable ksp in test sources #10934

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update secrets to disable ksp in test sources #10934

merged 1 commit into from
Feb 27, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 27, 2024

This PR is complementary to #10931 . I forgot that to update secrets, we also have to pin the hash pointing to the newer version of secrets.

@wzieba wzieba added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Feb 27, 2024
@wzieba wzieba added this to the 17.6 milestone Feb 27, 2024
@wzieba wzieba requested a review from malinajirka February 27, 2024 08:34
malinajirka
malinajirka approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, I forgot this was necessary. Thanks!

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit2e8b30c
Direct Downloadwoocommerce-prototype-build-pr10934-2e8b30c.apk

@malinajirka malinajirka merged commit ab90b95 into trunk Feb 27, 2024
12 of 17 checks passed
@malinajirka malinajirka deleted the update_secrets branch February 27, 2024 08:54
@wzieba wzieba mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka approved these changes

Assignees
No one assigned
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Milestone
17.6
Development

Successfully merging this pull request may close these issues.
3 participants
@wzieba @wpmobilebot @malinajirka