Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: fix issue labels validation #10894

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

iangmaia
Copy link
Contributor

This PR fixes the regex applied when we run labels validations on issues.
The ending part of the regex *$ isn't really necessary and was breaking the regex match.

@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Feb 22, 2024
@iangmaia iangmaia requested a review from rachelmcr February 22, 2024 15:27
@iangmaia iangmaia self-assigned this Feb 22, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit3e051e2
Direct Downloadwoocommerce-prototype-build-pr10894-3e051e2.apk

Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the Dangermattic workflow this ties in with, but this change looks good for matching labels starting with type: and feature: .

If we wanted to use regex that matches the entire label we could check for ^type: .+ and ^feature: .+, but that's only needed for exact matches.

@iangmaia
Copy link
Contributor Author

I'm not too familiar with the Dangermattic workflow this ties in with, but this change looks good for matching labels starting with type: and feature: .

If we wanted to use regex that matches the entire label we could check for ^type: .+ and ^feature: .+, but that's only needed for exact matches.

Good suggestion, though! I'll add it just to be a bit more precise.

@iangmaia iangmaia enabled auto-merge February 22, 2024 17:12
@iangmaia iangmaia merged commit cc11f60 into trunk Feb 22, 2024
14 checks passed
@iangmaia iangmaia deleted the iangmaia/issue-validation-regex-fix branch February 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants