Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Better Tablet Products] Adapt toolbar for the 2 pane layout on the details part #10866

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Feb 20, 2024

Closes: #10843

Description

The PR adds usage of the fragment's toolbar for Product Details screen, instead of the one from the activity. This needed to have proper support on the tablets.

Testing instructions

  • The most important to make sure that there is not regression brought to the case when FF is OFF.
  • There is one obvious regression that also exists in the orders tablet support is we animate the toolbar now, but we accept that for now

Images/gif

02-21--09-04.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 20, 2024

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class ProductDetailsToolbarHelper is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@kidinov kidinov added category: tablet Specific to tablet devices such as a Galaxy Tab or an iPad. feature: order details Related to order details. labels Feb 20, 2024
@kidinov kidinov added this to the 17.5 milestone Feb 20, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 20, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitf79a07b
Direct Downloadwoocommerce-prototype-build-pr10866-f79a07b.apk

…ne-layout' into 10843-better-tablet-products-adapt-toolbar-for-the-2-pane-layout-on-the-details-part
@kidinov kidinov requested a review from samiuelson February 21, 2024 08:10
@kidinov kidinov added feature: product details Related to adding or editing products, includes product settings. and removed feature: order details Related to order details. labels Feb 21, 2024
@kidinov kidinov requested a review from a team as a code owner February 21, 2024 10:21
Copy link
Contributor

@jostnes jostnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @kidinov thanks for updating the id to fix the test. the e2eProductListShowsAllProducts however was failing when i ran it locally on tablet emulator (we're currently not running on tablet emulators on the CI), i added a fix in 44c0e2b commit so at least there's flexibility to run it locally until the CI set up is in place.

i didn't review the changes in main directory, but approving from a test perspective.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 102 lines in your changes are missing coverage. Please review.

Project coverage is 41.14%. Comparing base (ca19633) to head (f79a07b).
Report is 3 commits behind head on trunk.

Files Patch % Lines
...android/ui/products/ProductDetailsToolbarHelper.kt 0.00% 99 Missing ⚠️
...oocommerce/android/util/TabletLayoutSetupHelper.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #10866      +/-   ##
============================================
- Coverage     41.21%   41.14%   -0.07%     
  Complexity     5057     5057              
============================================
  Files          1028     1029       +1     
  Lines         59415    59512      +97     
  Branches       7971     8000      +29     
============================================
  Hits          24489    24489              
- Misses        32755    32852      +97     
  Partials       2171     2171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 10830-better-tablet-products-adapt-toolbar-for-the-2-pane-layout to trunk February 22, 2024 09:35
@kidinov kidinov modified the milestones: 17.5, 17.6 Feb 23, 2024
@samiuelson samiuelson self-assigned this Feb 26, 2024
Copy link
Collaborator

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiuelson samiuelson merged commit 26d3ff6 into trunk Feb 26, 2024
16 of 17 checks passed
@samiuelson samiuelson deleted the 10843-better-tablet-products-adapt-toolbar-for-the-2-pane-layout-on-the-details-part branch February 26, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tablet Specific to tablet devices such as a Galaxy Tab or an iPad. feature: product details Related to adding or editing products, includes product settings. unit-tests-exemption
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Better Tablet Products] Adapt toolbar for the 2 pane layout on the details part
6 participants