-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Better Tablet Products] Adapt toolbar for the 2 pane layout on the details part #10866
[Better Tablet Products] Adapt toolbar for the 2 pane layout on the details part #10866
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…ne-layout' into 10843-better-tablet-products-adapt-toolbar-for-the-2-pane-layout-on-the-details-part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @kidinov thanks for updating the id to fix the test. the e2eProductListShowsAllProducts
however was failing when i ran it locally on tablet emulator (we're currently not running on tablet emulators on the CI), i added a fix in 44c0e2b commit so at least there's flexibility to run it locally until the CI set up is in place.
i didn't review the changes in main
directory, but approving from a test perspective.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #10866 +/- ##
============================================
- Coverage 41.21% 41.14% -0.07%
Complexity 5057 5057
============================================
Files 1028 1029 +1
Lines 59415 59512 +97
Branches 7971 8000 +29
============================================
Hits 24489 24489
- Misses 32755 32852 +97
Partials 2171 2171 ☔ View full report in Codecov by Sentry. |
…for-the-2-pane-layout-on-the-details-part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #10843
Description
The PR adds usage of the fragment's toolbar for Product Details screen, instead of the one from the activity. This needed to have proper support on the tablets.
Testing instructions
Images/gif
02-21--09-04.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.