This repository was archived by the owner on Oct 4, 2019. It is now read-only.
Add a fix for keeping the site title and email footer in sync. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think a more ideal fix for core would be for the inclusion of the site title to be something that happens as a replacement in the user defined string so that it stays in sync unless the user removes the replacement marker. |
allendav
reviewed
Jul 26, 2017
| function wc_api_dev_email_from_name( $name ) { | ||
| return get_bloginfo( 'name', 'display' ); | ||
| } | ||
| add_filter( 'woocommerce_email_from_name', 'wc_api_dev_email_from_name', 20 ); |
There was a problem hiding this comment.
Why priority 20 here and below? Maybe add a comment why 20 is needed.
allendav
approved these changes
Jul 26, 2017
emdashcodes
force-pushed
the
add/email-filters-fix
branch
from
303ffb1 to
844c5d9
Compare
emdashcodes
force-pushed
the
add/email-filters-fix
branch
from
844c5d9 to
c5fd07c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ryelle @allendav This should help with Automattic/wp-calypso#16445.
This really makes me wish we had an additional plugin for things like this (since it is not something we want in core as-is), but as I mentioned on the call, I think this will be fine for now as long as we keep these things in hotfixes. And maybe add to the GitHub README in a separate PR.
I haven't bumped the version here since @ryelle already is. These can go in the same release.
To Test:
/store/order/{domain}/{orderID}and fulfill an order, giving it a tracking number (make anything up) and checking the "send to customer" box.