Skip to content

Use proper escape function in comments template #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

Use proper escape function in comments template #1576

merged 1 commit into from
Jan 11, 2021

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Jan 7, 2021 •
edited
Loading

The comment template was using an incorrect escape function for the datetime attribute in the comments template.

This PR updates the code to use esc_attr for the datetime attribute instead of esc_html.

How to test the changes in this Pull Request:

  1. View a blog post that has some comments.
  2. Ensure the comment date is displayed and that the datetime attribute is set.

Changelog

Fix - Use proper escape function for datetime attribute in comments template. #1576

@donnapep donnapep self-assigned this Jan 7, 2021
@donnapep donnapep requested a review from a team as a code owner January 7, 2021 15:53
@donnapep donnapep requested review from budzanowski and removed request for a team January 7, 2021 15:53
Aljullu
Aljullu approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @donnapep!

@Aljullu Aljullu added this to the 3.2.0 milestone Jan 11, 2021
@Aljullu Aljullu merged commit 1ef384c into trunk Jan 11, 2021
@Aljullu Aljullu deleted the fix/escape-function branch January 11, 2021 15:28
Yourgene pushed a commit to Yourgene/storefront that referenced this pull request Jan 12, 2021
@donnapep @Yourgene
Use proper escape function (woocommerce#1576)
74e9a84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aljullu Aljullu Aljullu approved these changes

@budzanowski budzanowski Awaiting requested review from budzanowski

Assignees

@donnapep donnapep

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@donnapep @Aljullu