Align PHP require version to composer.json #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog: tweak
ibndawood
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Thank you, @rawdreeg. I've made some changes. Here is the plugin header details: https://developer.wordpress.org/plugins/plugin-basics/header-requirements/
Co-authored-by: Kader Ibrahim S <kader.ibrahim.s@a8c.com>
|
Thanks @ibndawood , for the Requires at least, shouldn't that be 5.6? I have updated this here: e356a5a |
|
I just used the same value as in WooCommerce core here: https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/woocommerce.php |
ibndawood
approved these changes
Jul 11, 2024
Ah neat. We can make another PR to adjust the minimum required WP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR make changes to align PHP require version to composer.json
phpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Changelog entry