Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hidden files from build archive #2747

Merged
merged 1 commit into from
May 20, 2024
Merged

Remove hidden files from build archive #2747

merged 1 commit into from
May 20, 2024

Conversation

ibndawood
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #2693.

This PR removes hidden files from the build archive by adding them to .gitattributes file.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Detailed test instructions:

  1. Run npm run build.
  2. Earlier files listed in Do not bundle hidden files in the build archive #2693 are added.
  3. With this PR, verify the files listed in Do not bundle hidden files in the build archive #2693 are not added.

Changelog entry

Tweak - Remove hidden files from build archive

@ibndawood ibndawood requested a review from a team May 17, 2024 14:33
@ibndawood ibndawood self-assigned this May 17, 2024
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels May 17, 2024
rawdreeg
rawdreeg approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@rawdreeg rawdreeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@ibndawood ibndawood merged commit 87e5b84 into develop May 20, 2024
1 check passed
@ibndawood ibndawood deleted the fix/2693-hidden-files branch May 20, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawdreeg rawdreeg rawdreeg approved these changes

Assignees

@ibndawood ibndawood

Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not bundle hidden files in the build archive
2 participants
@ibndawood @rawdreeg