This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fixed slider.play() leaving unstoppable setIntervals. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you call slider.play() more than once in a row, previous intervals are not cleared. Reference is lost to them, so they can never be stopped again and stack up. The fix calls clearInterval first if the slider is already playing.
|
Merged manually. Thank you! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call slider.play() more than once in a row, previous intervals are not cleared. Reference is lost to them, so they can never be stopped again and stack up. The fix calls clearInterval first if the slider is already playing.