Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Corrected slider.itemW ignoring slideMargins #1434

Closed
wants to merge 1 commit into from
Closed

Corrected slider.itemW ignoring slideMargins #1434

wants to merge 1 commit into from

Conversation

florianjacob
Copy link

The current slider.itemW calculation didn't take slideMargin into account, resulting in the behaviour described in #1433.

@florianjacob
Corrected slider.itemW ignoring slideMargins
7a8287a 
The current slider.itemW calculation didn't take slideMargin into account, resulting in the behaviour described in woocommerce#1433.
@jeffikus jeffikus self-assigned this Sep 21, 2015
@jeffikus jeffikus added this to the 2.6.0 milestone Sep 21, 2015
@florianjacob
Copy link
Author

Seems like the calculation is still incorrect.

@jeffikus
Copy link
Contributor

@florianjacob how come you closed this? I've assigned it for the 2.6.0 milestone?

@florianjacob
Copy link
Author

@jeffikus Because I'm not sure anymore whether fixing #1433 is actually as trivial as my commit.
I think I don't understand enough of flexslider to solve this on my own, reopening though for help and keeping track of it for 2.6.0.

I noticed that with my commit, itemWidth + itemMargin is now assigned as width to the <li>, but itemMargin should actually be the margin between <li>s, I'd say, or is it actually meant to be a margin between <li> and an inner element?

@florianjacob florianjacob reopened this Sep 23, 2015
jeffikus added a commit that referenced this pull request Oct 5, 2015
@jeffikus
Closes #1434 - adds itemMargin to the slider margin-right for slider …
6324790 
…items.
@jeffikus
Copy link
Contributor

jeffikus commented Oct 5, 2015

Ok, so you are correct, it wasn't as simple as your fix above, but I've added a fix now, the marginRight property was not being added to the elements. That should be sorted now.

@jeffikus jeffikus closed this Oct 5, 2015
This was referenced Oct 5, 2015
Closed
Closed
@florianjacob
Copy link
Author

The commit only fixed issue #1373 , not #1433, which is more specific. More details at my new #1433 comment.

@jeffikus jeffikus mentioned this pull request Nov 16, 2015
Merged
floq-design added a commit to floq-design/FlexSlider that referenced this pull request Nov 16, 2015
@floq-design
Merge commit '09d7c72e585dca59891cd6f38a126e37bd30300e' into sass
2049b84 
* commit '09d7c72e585dca59891cd6f38a126e37bd30300e':
  Typo for composter to composer.
  Updates bower and npm versions, updates readme and changelog.
  Fixes accessibility issue on pagination controls.
  CSS version number updated to 2.6.0
  Version number updated to 2.6.0
  Closes woocommerce#1389 and Closes woocommerce#1390 - adds data-thumb-alt image alt attribute output
  Closes woocommerce#1419 - removes text select for Firefox issue on carousel and thumbnail image navigation selection.
  Closes woocommerce#646 - updates demo with solution from @nsickness
  Closes woocommerce#1431	- fixes accessibility issue for focus elements
  Closes woocommerce#1434 - adds itemMargin to the slider margin-right for slider items.
  Closes woocommerce#1368 - fix for play pause accessibility issue. Future implementation will most likely use Aria based controls.
  Closes woocommerce#1380 - z-index change to stop disabled arrow nav from being clickable.
  Closes woocommerce#1376 - excuses demo folder from bower
  Updates demo viewport param separators - closes woocommerce#1382
  Closes woocommerce#1421
  Updates keywords for composer file.
  Closes woocommerce#1388 - fix demo video player link
  Create composer.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jeffikus jeffikus

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@florianjacob @jeffikus