Skip to content

Remove gradle deprecations, correctly cache asset gradle tasks, publish gradle plugin correctly, and build clean up #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2025
Merged

Remove gradle deprecations, correctly cache asset gradle tasks, publish gradle plugin correctly, and build clean up #378

merged 5 commits into from
Jun 18, 2025

Conversation

jdaugherty
Copy link
Contributor

No description provided.

@jdaugherty jdaugherty requested a review from davydotcom June 14, 2025 00:38
@jdaugherty
Copy link
Contributor Author

The one thing I did not fix is the asset cache location isn't correctly set for tests, so that's why an '.assetcache' gets created at the root. I did add a warning so we can fix this in the future.

@jdaugherty jdaugherty mentioned this pull request Jun 14, 2025
Merged
@jdaugherty
Copy link
Contributor Author

@jamesfredley @matrei if either of you have the time to also review this, it would be appreciated.

matrei
matrei approved these changes Jun 17, 2025
View reviewed changes
@davydotcom davydotcom merged commit c9ebc2b into 5.0.x Jun 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydotcom davydotcom Awaiting requested review from davydotcom

1 more reviewer

@matrei matrei matrei approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdaugherty @matrei @davydotcom