Skip to content

Comments

Bump flutter and dependencies versions, moved test folder#383

Open
nestorsgarzonc wants to merge 1 commit intowoltapp:mainfrom
nestorsgarzonc:chore/bump-dependency-versions-and-fixed-test-folder
Open

Bump flutter and dependencies versions, moved test folder#383
nestorsgarzonc wants to merge 1 commit intowoltapp:mainfrom
nestorsgarzonc:chore/bump-dependency-versions-and-fixed-test-folder

Conversation

@nestorsgarzonc
Copy link

@nestorsgarzonc nestorsgarzonc commented Jun 21, 2025

Description

Refactor modal sheet layout and type constructors for improved readability and consistency

  • Updated WoltModalSheetLayout to use super.key in constructor.
  • Refactored WoltBottomSheetType, WoltDialogType, and WoltSideSheetType constructors to utilize super for parameters.
  • Simplified WoltAnimatedModalBarrier and WoltStickyActionBarWrapper constructors by using super.key.
  • Modified WoltModalSheetRoute to use super.settings in constructor.
  • Removed library name in wolt_modal_sheet.dart for cleaner export.
  • Updated dependency injector to use super.key and super.child.
  • Updated pubspec.yaml files for wolt_di and wolt_state_management to reflect new SDK and Flutter versions, and updated dev dependencies.
  • Added comprehensive tests for StatefulValueNotifier and ValueState classes to ensure correct behavior across various states and transitions.
  • Added new test files for stateful value notifier and value state to enhance test coverage.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…ility and consistency

- Updated WoltModalSheetLayout to use super.key in constructor.
- Refactored WoltBottomSheetType, WoltDialogType, and WoltSideSheetType constructors to utilize super for parameters.
- Simplified WoltAnimatedModalBarrier and WoltStickyActionBarWrapper constructors by using super.key.
- Modified WoltModalSheetRoute to use super.settings in constructor.
- Removed library name in wolt_modal_sheet.dart for cleaner export.
- Updated dependency injector to use super.key and super.child.
- Updated pubspec.yaml files for wolt_di and wolt_state_management to reflect new SDK and Flutter versions, and updated dev dependencies.
- Added comprehensive tests for StatefulValueNotifier and ValueState classes to ensure correct behavior across various states and transitions.
- Added new test files for stateful value notifier and value state to enhance test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant