Enable drag to dismiss modal if the scroll position is at top edge #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
reviewed
Jul 31, 2024
lib/src/content/components/main_content/wolt_modal_sheet_main_content.dart
Outdated
Show resolved
Hide resolved
ulusoyca
reviewed
Jul 31, 2024
|
@AcarFurkan Thanks for the great solution! I found a cleaner way to achieve the same. What do you think? |
ulusoyca
reviewed
Jul 31, 2024
ulusoyca
force-pushed
the
add-draggability-to-content
branch
from
e2cba3d
to
e018bf5
Compare
ulusoyca
force-pushed
the
add-draggability-to-content
branch
from
e018bf5
to
6680510
Compare
ulusoyca
changed the title
ulusoyca
force-pushed
the
add-draggability-to-content
branch
from
e4245fc
to
29513fa
Compare
ulusoyca
approved these changes
Aug 1, 2024
TahaTesser
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the existing implementation, modals with lengthy, scrollable content could only be dismissed using the drag gesture on the drag handle at top.
With the changes introduced in this PR, modals can now be dismissed by initiating a drag on anywhere in the page content in the permitted dismiss direction, as specified by the modal type configuration. This is possible only when the modal's scroll position is at the top (scroll position at 0).
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-31.at.18.59.08.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-31.at.19.00.18.mp4
This not only works for bottom sheet but also works on all custom modals considering their dismiss direction. Here is the example:
drag_to_close_custom_modal.mov
Related Issues
#262
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?