Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment: Renamed WoltModalSheetRoute routeSettings to settings #268

Conversation

durannumit
Copy link
Collaborator

Description

In order to stay consistent with the Router API of Flutter, we should rename routeSettings field as settings field.

Related Issues

fix: Rename [WoltModalSheetRoute.routeSettings] fields as [WoltModalSheetRoute.settings]

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@durannumit durannumit self-assigned this Jul 18, 2024
@durannumit durannumit merged commit 5cd4a7b into woltapp:main Jul 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename [WoltModalSheetRoute.routeSettings] fields as [WoltModalSheetRoute.settings]
2 participants