Hot Reload

[dickermoshe]

Bug report

Describe the bug
When making changes to an open bottom sheet, it isn't rebuilt

Steps to reproduce

Steps to reproduce the behavior:

1. Open Bottom Sheet
2. Edit Widget
3. Hot Restart

Expected behavior

See changes instantly

---

Additional context

This seems to be a general issue, but being that with dialogs and bottom sheets, but those can be wrapped in a custom widget workaround it.
Having to open and close it during development isn't great.
Is there something I'm missing?

---

[felipecastrosales]

hey! this appears here also. @dickermoshe any expectations?

[dickermoshe]

hey! this appears here also. @dickermoshe any expectations?

Say What? I don't understand the question.

[dickermoshe]

The workaround for this issue is to wrap the base widget in a StatefulBuilder

[felipecastrosales]

@dickermoshe I've been trying this - because in common bottomsheets I do this, but it didn't work with this package for me. Can you send me how you implemented it?

[dickermoshe]

mainContentSlivers: [
      SliverToBoxAdapter(
        child: StatefulBuilder(builder: (ctx, _) {
          return Container(color:Colors.red, height:50,width: 50); // Any widget in here will rebuild on a hot reload
        }),
      ),
    ],

[felipecastrosales]

and how make with WoltModalSheetPage? in child doesn't works as expected. I think this plugin can put this internally, or in documents explain about the use of StatefulBuilder and where it can be added; with this we can close this issue - IMHO.

mainContentSlivers: [
      SliverToBoxAdapter(
        child: StatefulBuilder(builder: (ctx, _) {
          return Container(color:Colors.red, height:50,width: 50); // Any widget in here will rebuild on a hot reload
        }),
      ),
    ],

[dickermoshe]

I agree, @ulusoyca
What do you think about wrapping every widget in a StatefulBuilder under the hood?

(Sorry if I shouldn't be pinging people)

[ulusoyca]

@dickermoshe How about this one? This still won't solve the hot reload issue, but I think this is easier way to update the current page without decorator, builders and value listenable builders

#213

[felipecastrosales]

I keep thinking that it's a problem not to have a hot-reload when using this package, cc @ulusoyca. Yesterday I took a quick look at the package and couldn't identify what it could be.

[ulusoyca]

@felipecastrosales Indeed identifying the problem is a bit difficult. I thought I fixed it with #213 but nope. Hot reload partly works.

We will work on a larger refactor in H2. Fingers crossed 🤞🏻

[dickermoshe]

@ulusoyca
I'm just wondering, what's wrong with wrapping each widget with a stateful builder under the hood?
Seems like a good temporary fix

[ulusoyca]

@ulusoyca I'm just wondering, what's wrong with wrapping each widget with a stateful builder under the hood? Seems like a good temporary fix

No problem at all, but how does it work? I am not sure how hot reload would work when it is done but very interested in learning. Do you mind showing with a PR?

BTW; what do you think about #213?

[dickermoshe]

I really wish I knew why it worked, but it does. I’ve had this experience working on the Google pay plug-in for flutter, where we had to make a widget stateful in order for hot-reload to work. I’ll work on a PR later. If you know anyone who has an advanced understanding of flutters architecture, I’m sure you could ask them.

…

On Tue, May 28, 2024 at 9:21 AM Cagatay Ulusoy ***@***.***> wrote: @ulusoyca <https://github.com/ulusoyca> I'm just wondering, what's wrong with wrapping each widget with a stateful builder under the hood? Seems like a good temporary fix No problem at all, but how does it work? I am not sure how hot reload would work when it is done but very interested in learning. Do you mind showing with a PR? BTW; what do you think about #213 <#213>? — Reply to this email directly, view it on GitHub <#178 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASDJ623YETABUUEJR256T33ZESAF5AVCNFSM6AAAAABF5DWNWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGIYDIOBUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[venbrinoDev]

Still having issue with hot reload using the WoltModalSheetPage

anyone got any fix to this yet?