Upgrading behat to 2.4 and additional required changes

remove initialization of mink and behat bundles
add project directory level behat.yml initial spec
remove behat mink configuration from symfony config files
remove old composer.lock and update vendors
add composer lock file for upgrade
fix travis call for behat script and make behat-ci script executable
move behat-ci.sh inside bin directory
fix behat-ci script
adapt Behat Contexts to running state
add mink selenium driver
enable minkcontext steps
ignore behat.yml and make dist version of configuration
embed behat deps on require-dev
shorten namespaces
remove nulls from declaration of kernel vars
remove useless if
remove sellenium, sahi

.gitignore

@@ -20,4 +20,6 @@ composer.phar
 bin/*
 !bin/launch-rabit-consumers.sh
 !bin/prepare-*.sh
-
+!bin/behat-*.sh
+build
+behat.yml

.travis.yml

@@ -12,7 +12,9 @@ before_script:
     - ./bin/prepare-test-solr.sh
     - ./bin/prepare-test-gd.sh
 
-script: phpunit -c app/ && php app/console --env=test behat --format progress
+script:
+    - phpunit -c app/
+    - ./bin/behat-ci.sh
 
 branches:
     except:

app/AppKernel.php

@@ -38,11 +38,6 @@ public function registerBundles()
             new Knp\Bundle\SitemapBundle\KnpSitemapBundle(),
         );
 
-        if ('test' === $this->getEnvironment()) {
-            $bundles[] = new Behat\BehatBundle\BehatBundle();
-            $bundles[] = new Behat\MinkBundle\MinkBundle();
-        }
-
         if ($this->isDebug()) {
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
         }

app/config/config_test.yml

@@ -9,6 +9,3 @@ framework:
 web_profiler:
     toolbar: false
     intercept_redirects: false
-
-mink:
-    show_cmd: firefox %s

behat.yml.dist

@@ -0,0 +1,12 @@
+default:
+  formatter:
+    name: progress
+  extensions:
+    Behat\Symfony2Extension\Extension:
+      mink_driver: true
+      kernel:
+        env: test
+        debug: true
+    Behat\MinkExtension\Extension:
+      base_url: 'http://knpbundles.local/app_test.php/'
+      default_session: symfony2

bin/behat-ci.sh

@@ -0,0 +1,42 @@
+#!/bin/bash
+
+# ./bin/behat-ci.sh
+
+project_dir=$(dirname $(readlink -f $0))"/.."
+logs_path=${1:-"./build/logs/behat"}
+reports_path=${2:-"./build/behat"}
+
+check_and_create_dir() {
+    path=$1
+    echo $path
+    if [[ -d "$path" ]]; then
+        # Directory already exists, do nothing
+        : echo "Directory already exists"
+    elif [[ -e "$path" ]]; then
+        echo "$path exists and is not a directory";
+    else
+        mkdir -p $path
+    fi
+}
+
+check_and_create_dir $reports_path
+check_and_create_dir $logs_path
+
+cd $project_dir
+
+logs_path=${logs_path##$(pwd)/}
+reports_path=${reports_path##$(pwd)/}
+
+for feature_path in `find src/ -path '*/Features'`; do
+    var=`echo $feature_path`;
+    var2=${var%Bundle*};
+    bundle=`echo "${var2##*/}Bundle"`
+    reports_dir=$reports_path"/$bundle.html"
+
+    echo "Running suite for $bundle";
+
+    ./bin/behat --format=progress,junit,html --out=,$logs_path,$reports_dir "@$bundle";
+    echo "<a href=\"$bundle.html\">$bundle</a><br />" >> $reports_path"/index.html"
+done
+
+cd -

composer.json

@@ -13,12 +13,6 @@
         "symfony/monolog-bundle": "*",
         "sensio/distribution-bundle": "*",
         "jms/i18n-routing-bundle": "*",
-
-        "behat/behat": "2.3.*",
-        "behat/behat-bundle": "*",
-        "behat/mink-bundle": "*",
-        "behat/common-contexts": "1.1.*",
-
         "doctrine/doctrine-fixtures-bundle": "*",
         "doctrine/doctrine-migrations-bundle": "*",
         "stof/doctrine-extensions-bundle": "*",
@@ -47,12 +41,14 @@
 
         "mbontemps/oauth-bundle": "*"
     },
-
+    "require-dev": {
+        "behat/behat":                  "*",
+        "behat/symfony2-extension":     "*",
+        "behat/mink-extension":         "*",
+        "behat/mink-browserkit-driver": "*",
+        "behat/common-contexts": "*"
+    },
     "repositories": [
-        {
-            "type": "composer",
-            "url": "behat.org"
-        },
         {
             "type": "package",
             "package": {

src/Knp/Bundle/KnpBundlesBundle/Features/Context/FeatureContext.php

@@ -2,15 +2,14 @@
 
 namespace Knp\Bundle\KnpBundlesBundle\Features\Context;
 
-use Behat\BehatBundle\Context\BehatContext,
-    Behat\BehatBundle\Context\MinkContext;
-
-use Behat\MinkBundle\Driver\SymfonyDriver;
-
 use Behat\Behat\Context\ClosuredContextInterface,
     Behat\Behat\Context\Step,
     Behat\Behat\Context\TranslatedContextInterface,
     Behat\Behat\Exception\PendingException;
+use Behat\CommonContexts\SymfonyDoctrineContext;
+use Behat\MinkExtension\Context\MinkContext;
+use Behat\Symfony2Extension\Context\KernelAwareInterface;
+use Behat\MinkExtension\Context\RawMinkContext;
 use Behat\Gherkin\Node\PyStringNode,
     Behat\Gherkin\Node\TableNode;
 
@@ -21,6 +20,8 @@
     Behat\Mink\Exception\ElementTextException,
     Behat\Mink\Exception\UnsupportedDriverActionException;
 
+use Symfony\Component\HttpKernel\KernelInterface;
+
 use Etcpasswd\OAuthBundle\Security\Core\Authentication\Token\OAuthToken,
     Etcpasswd\OAuthBundle\Provider\Token\GithubToken;
 
@@ -33,18 +34,22 @@
 /**
  * Feature context.
  */
-class FeatureContext extends MinkContext
+class FeatureContext extends RawMinkContext implements KernelAwareInterface
 {
     private $users;
     private $bundles;
     private $keywords;
 
+    /**
+     * @var \Symfony\Component\HttpKernel\KernelInterface $kernel
+     */
+    private $kernel;
+
     public function __construct($kernel)
     {
-        $this->useContext('symfony_doctrine', new \Behat\CommonContexts\SymfonyDoctrineContext($kernel));
-        $this->useContext('solr', new \Knp\Bundle\KnpBundlesBundle\Features\Context\SolrContext($kernel));
-
-        parent::__construct($kernel);
+        $this->useContext('symfony_doctrine', new SymfonyDoctrineContext());
+        $this->useContext('solr', new SolrContext());
+        $this->useContext('mink', new MinkContext());
     }
 
     /**
@@ -353,4 +358,24 @@ protected function getRouter()
     {
         return $this->getContainer()->get('router');
     }
+
+    /**
+     * gets container from kernel
+     * 
+     * @return \Symfony\Component\DependencyInjection\ContainerInterface
+     */
+    protected function getContainer()
+    {
+        return $this->kernel->getContainer();
+    }
+
+    /**
+     * Sets Kernel instance.
+     *
+     * @param KernelInterface $kernel HttpKernel instance
+     */
+    public function setKernel(KernelInterface $kernel)
+    {
+        $this->kernel = $kernel;
+    }
 }