Minimum score threshold for trends

Extend tests
wolfwolker · Aug 20, 2012 · 2b2bab2 · 2b2bab2
1 parent 4d1ff37
commit 2b2bab2
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/app/config/parameters.yml.dist b/app/config/parameters.yml.dist
@@ -10,6 +10,7 @@ parameters:
 
     knp_bundles.trending_bundle_twitterer.idle_period: 30 #days
     knp_bundles.trending_bundle.min_score_diff: 3
+    knp_bundles.trending_bundle.min_score_threshold: 25
 
     knp_bundles.github.client_id: your_client_id_here
     knp_bundles.github.client_secret: your_client_secret_here

diff --git a/app/config/parameters.yml.test b/app/config/parameters.yml.test
@@ -10,6 +10,7 @@ parameters:
 
     knp_bundles.trending_bundle_twitterer.idle_period: 30 #days
     knp_bundles.trending_bundle.min_score_diff: 3
+    knp_bundles.trending_bundle.min_score_threshold: 25
 
     knp_bundles.github.client_id: b46912af13ee7cb7ecd3
     knp_bundles.github.client_secret: 116f5427707fcc2a3f7c630dd356be61500b2e18

diff --git a/src/Knp/Bundle/KnpBundlesBundle/Command/KbUpdateTrendsCommand.php b/src/Knp/Bundle/KnpBundlesBundle/Command/KbUpdateTrendsCommand.php
@@ -73,10 +73,12 @@ private function updateTrends()
   AND score.diff > %s
 
 SET trend1 = score.diff
+WHERE score >= %s
 EOF;
 
         $minDiff = $this->getContainer()->getParameter('knp_bundles.trending_bundle.min_score_diff');
-        $query = sprintf($sql, $minDiff);
+        $minThreshold = $this->getContainer()->getParameter('knp_bundles.trending_bundle.min_score_threshold');
+        $query = sprintf($sql, $minDiff, $minThreshold);
 
         $nbRows = $em->getConnection()->executeUpdate($query);
 

diff --git a/src/Knp/Bundle/KnpBundlesBundle/Tests/Commands/KbUpdateTrendsCommandTest.php b/src/Knp/Bundle/KnpBundlesBundle/Tests/Commands/KbUpdateTrendsCommandTest.php
@@ -44,7 +44,7 @@ public function setUp()
         foreach ($data['bundles'] as $bundleName => $bundleData) {
             $bundle = new Bundle('vendor/' . $bundleName);
             $bundle->setDescription('some description');
-            $bundle->setScore(0);
+            $bundle->setScore(100);
             $bundle->setUser($user);
 
             foreach ($bundleData['scores'] as $scoreData) {