Fix scrolling speed for touchpads and high-res wheels on Wayland #1250
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular mice send a value of 15 for one wheel tick, not 8. This currently doesn't change anything about vertical scrolling since it's handled discretely, but that will change in the next commit.
Before this commit, vertical scroll was always discrete. At least on Wayland, this caused extremely fast scrolling on touchpads (that send lots of small axis events) and on mice with high-resolution wheels (that also send lots of small axis events). After this commit, all of this scrolling works correctly, at a speed matching regular wheels.
Contributor
Author
|
There's still a problem with the frame overview zoom, but there it can't be as easily fixed because the zoom levels are discrete. Would need some accumulator for |
Owner
Well, you broke emscripten :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, vertical scroll was always discrete. At least on Wayland, this caused extremely fast scrolling on touchpads (that send lots of small axis events) and on mice with high-resolution wheels (that also send lots of small axis events). After this change, all of this scrolling works correctly, at a speed matching regular wheels.
I adjusted the Wayland PointerAxis multiplier in such a way as to preserve the scrolling speed for regular mice. I don't know about other backends, they may need to be adjusted too.
Before:
tracy-scroll-before.mp4
After:
tracy-scroll-after.mp4