Skip to content

Conversation

@luisaveiro
Copy link
Member

@luisaveiro luisaveiro commented Nov 20, 2024

Purpose

This branch includes the following:

Refactoring
  • The structure of the tests and folders has been changed to improve overall structure and folder navigation.
  • Improvements in the tests by validating the assertions from MSW mocked responses
Fixes
  • The URL structure would include an unnecessary trailing slash. This is resolved.
  • Fixed the buildUrl() logic to prevent duplicate slashes in the URL structure
  • Fixed the detecting Mocked Response URL logic to support the new URL structure
  • Fixed requests that contain form data not sending the data.
Improvements
  • Implemented a custom Multipart Data Serializer class. This is due to the Content-Type header being set manually.

Related Issue

Please link to the issue/discussion here: N/A


Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).
  • Refactoring.
  • Other (documentation).

Are breaking changes introduced?


How Has This Been Tested?

  • Changes are covered by existing tests.
  • Changes are covered by new tests.
  • Changes are not covered by tests.

Development Checklist

  • My code follows our coding standards.
  • All new and existing tests passed.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG accordingly.
  • I have updated the README, if necessary.

@luisaveiro luisaveiro added bug Something isn't working refactoring Restructuring code while not changing its original functionality labels Nov 20, 2024
@luisaveiro luisaveiro self-assigned this Nov 20, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@luisaveiro luisaveiro marked this pull request as ready for review November 30, 2024 18:09
@luisaveiro luisaveiro merged commit 61a9bf5 into main Dec 2, 2024
5 checks passed
@luisaveiro luisaveiro deleted the refactoring/improving-tests branch December 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactoring Restructuring code while not changing its original functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants