Skip to content

Conversation

@octo-sts
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 28, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 28, 2025
@octo-sts
Copy link
Contributor Author

octo-sts bot commented Jan 28, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error output and context provided, I'll analyze the build failure:

• Detected Error: The build appears to fail during the CMake configuration/build phase, though the specific error message isn't shown in the provided output.

• Error Category: Build Configuration

• Failure Point: CMake configuration and build step

• Root Cause Analysis: The failure is likely related to missing BUILD_TESTING configuration and AWS dependencies versioning. Recent CMake fixes in v0.8.4 suggest configuration issues.

• Suggested Fix:

  1. Add explicit AWS dependencies version constraints:
environment:
  contents:
    packages:
      - aws-c-cal-dev~=0.8.1
      - aws-c-common-dev~=0.10.9
      - aws-c-http-dev~=0.9.2
      - aws-c-io-dev~=0.15.3
  1. Modify the CMake configuration:
  - runs: |
      cmake -B build -G Ninja \
        -DCMAKE_INSTALL_PREFIX=/usr \
        -DCMAKE_INSTALL_LIBDIR=/usr/lib \
        -DBUILD_SHARED_LIBS=True \
        -DCMAKE_BUILD_TYPE=Release \
        -DBUILD_TESTING=OFF \
        -DCMAKE_PREFIX_PATH=/usr \
        ${CMAKE_CROSSOPTS:-}

• Explanation:

  • The recent CMake fixes in v0.8.4 suggest configuration issues that need explicit settings
  • Setting CMAKE_BUILD_TYPE to Release provides optimized builds
  • Explicit version constraints ensure compatibility with AWS dependencies
  • CMAKE_PREFIX_PATH helps locate dependencies correctly

• Additional Notes:

  • Consider adding -DCMAKE_POSITION_INDEPENDENT_CODE=ON if building shared libraries
  • The AWS C dependencies are tightly coupled, version alignment is critical

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 28, 2025
@debasishbsws debasishbsws self-assigned this Jan 29, 2025
- Replaced custom build steps with Melange standard CMake pipelines (configure, build, install).
- Set BUILD_TESTING=OFF as want_check was causing issues.
- Removed manual handling of aws-c-auth dev folder, as it is now managed upstream (see: awslabs/aws-c-auth#258).

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 29, 2025
@debasishbsws debasishbsws requested a review from a team January 29, 2025 17:47
@OddBloke OddBloke merged commit 421809f into main Jan 29, 2025
15 checks passed
@OddBloke OddBloke deleted the wolfictl-8f1d1bd4-9e21-4405-b66e-5c7b575b6590 branch January 29, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. request-version-update request for a newer version of a package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants