Skip to content

Conversation

@octo-sts
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 28, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 28, 2025
@octo-sts
Copy link
Contributor Author

octo-sts bot commented Jan 28, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the build error logs provided, I'll analyze and suggest fixes:

• Detected Error: The error log appears incomplete, but based on the package and environment, this looks like a CMake configuration issue related to aws-c-common dependency.

• Error Category: Dependency/Configuration

• Failure Point: CMake configuration stage

• Root Cause Analysis:
The package requires aws-c-common as a dependency, and the CMake configuration may not be properly finding or utilizing it.

• Suggested Fix:
Add the following to the cmake configuration in the pipeline:

  - runs: |
      if [ "$CBUILD" != "$CHOST" ]; then
        CMAKE_CROSSOPTS="-DCMAKE_SYSTEM_NAME=Linux -DCMAKE_HOST_SYSTEM_NAME=Linux"
      fi
      CFLAGS="$CFLAGS -flto=auto" \
      CXXFLAGS="$CXXFLAGS -flto=auto" \
      cmake -B build -G Ninja \
        -DCMAKE_INSTALL_PREFIX=/usr \
        -DCMAKE_INSTALL_LIBDIR=/usr/lib \
        -DBUILD_SHARED_LIBS=True \
        -DCMAKE_BUILD_TYPE=None \
        -DBUILD_TESTING="$(want_check && echo ON || echo OFF)" \
        -DCMAKE_PREFIX_PATH=/usr \
        $CMAKE_CROSSOPTS

• Explanation:
Adding -DCMAKE_PREFIX_PATH=/usr helps CMake locate the installed aws-c-common package. This is particularly important since the recent changes in the upstream (v0.2.3) included CMake fixes.

• Additional Notes:

  • The package requires aws-c-common-dev which is correctly listed in the dependencies
  • Recent upstream changes (PR add bazel package #101) included CMake fixes which may require explicit path configuration
  • The build system is using Ninja generator which is correct for Wolfi builds

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 28, 2025
…up dev package

- Set BUILD_TESTING=OFF as want_check was causing errors
- Use Melange standard cmake pipelines for configure, build, and install
- Remove manual handling of aws-checksums dev folder as it is now handled upstream (see: awslabs/aws-checksums#101)

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@debasishbsws debasishbsws self-assigned this Jan 29, 2025
@debasishbsws
Copy link
Member

requires #40735

@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 29, 2025
@debasishbsws debasishbsws requested a review from a team January 29, 2025 17:41
@OddBloke OddBloke merged commit 3f6845d into main Jan 29, 2025
15 checks passed
@OddBloke OddBloke deleted the wolfictl-274ea7c3-202c-4963-80a3-7fb35c66b606 branch January 29, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. request-version-update request for a newer version of a package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants