Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falco-no-driver/0.40.0 package update #40665

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 28, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 28, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 28, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: "make[3]: *** No rule to make target 'c-ares-prefix/src/c-ares/lib/libcares.a', needed by 'userspace/falco/falco'. Stop."

• Error Category: Dependency/Build Configuration

• Failure Point: Missing c-ares static library during linking phase

• Root Cause Analysis: The build system is unable to find the static c-ares library that's required for building Falco. This is likely because c-ares is being built as a shared library instead of a static library.

• Suggested Fix:
Add these build flags to the CMake configuration in the pipeline:

pipeline:
  - runs: |
      mkdir build && cd build
      cmake \
        -DCMAKE_BUILD_TYPE=Release \
        -DUSE_BUNDLED_DEPS=On \
        -DFALCO_ETC_DIR=/etc/falco \
        -DBUILD_FALCO_MODERN_BPF=ON \
        -DMODERN_BPF_SKEL_DIR=/tmp \
        -DBUILD_DRIVER=Off \
        -DBUILD_BPF=Off \
        -DBUILD_SHARED_LIBS=OFF \    # Add this line
        -DCARES_SHARED=OFF \         # Add this line
        -DFALCO_VERSION=${{package.version}} \
        ..

• Explanation:
The added flags will force c-ares and other dependencies to be built as static libraries instead of shared libraries, which is what Falco expects in this configuration. The -DBUILD_SHARED_LIBS=OFF ensures all libraries are built statically by default.

• Additional Notes:

  • The warnings about deprecated iterator usage are from gRPC and can be ignored
  • Make sure c-ares-dev package is installed in the environment section
  • Consider adding -DCMAKE_POSITION_INDEPENDENT_CODE=ON if you encounter any PIC-related errors

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 28, 2025
@OddBloke OddBloke self-assigned this Jan 28, 2025
@OddBloke OddBloke force-pushed the wolfictl-a6d04db3-90d0-4076-8a0b-a5c5ab98a87e branch 9 times, most recently from 4c36cfe to 6839b35 Compare January 28, 2025 18:50
@OddBloke OddBloke force-pushed the wolfictl-a6d04db3-90d0-4076-8a0b-a5c5ab98a87e branch from 6839b35 to d3b9ea7 Compare January 29, 2025 08:32
@OddBloke OddBloke force-pushed the wolfictl-a6d04db3-90d0-4076-8a0b-a5c5ab98a87e branch from d3b9ea7 to 36c92a6 Compare January 29, 2025 08:38
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Jan 29, 2025
@OddBloke
Copy link
Member

Marking as Blocked pending a conversation about whether we still need this package in addition to falco.

@OddBloke OddBloke marked this pull request as draft January 30, 2025 12:17
@powersj
Copy link
Member

powersj commented Feb 7, 2025

@OddBloke what is the status of this one?

@OddBloke
Copy link
Member

OddBloke commented Feb 7, 2025

@OddBloke what is the status of this one?

We're blocked on testing the changes to confirm the changes to the build are acceptable, due to a latent issue in the image configuration.

@OddBloke OddBloke added the help wanted Extra attention is needed label Feb 7, 2025
@cmwilson21
Copy link
Member

Just saw that the escalation (https://github.com/chainguard-dev/internal-dev/issues/9057) was closed last week after this PR was merged. Did that clear the path on this one, @OddBloke?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. help wanted Extra attention is needed manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants