-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
falco-no-driver/0.40.0 package update #40665
base: main
Are you sure you want to change the base?
Conversation
octo-sts
bot
commented
Jan 28, 2025
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: • Detected Error: "make[3]: *** No rule to make target 'c-ares-prefix/src/c-ares/lib/libcares.a', needed by 'userspace/falco/falco'. Stop." • Error Category: Dependency/Build Configuration • Failure Point: Missing c-ares static library during linking phase • Root Cause Analysis: The build system is unable to find the static c-ares library that's required for building Falco. This is likely because c-ares is being built as a shared library instead of a static library. • Suggested Fix: pipeline:
- runs: |
mkdir build && cd build
cmake \
-DCMAKE_BUILD_TYPE=Release \
-DUSE_BUNDLED_DEPS=On \
-DFALCO_ETC_DIR=/etc/falco \
-DBUILD_FALCO_MODERN_BPF=ON \
-DMODERN_BPF_SKEL_DIR=/tmp \
-DBUILD_DRIVER=Off \
-DBUILD_BPF=Off \
-DBUILD_SHARED_LIBS=OFF \ # Add this line
-DCARES_SHARED=OFF \ # Add this line
-DFALCO_VERSION=${{package.version}} \
.. • Explanation: • Additional Notes:
• References:
|
4c36cfe
to
6839b35
Compare
Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
6839b35
to
d3b9ea7
Compare
d3b9ea7
to
36c92a6
Compare
Marking as Blocked pending a conversation about whether we still need this package in addition to |
@OddBloke what is the status of this one? |
We're blocked on testing the changes to confirm the changes to the build are acceptable, due to a latent issue in the image configuration. |
Just saw that the escalation (https://github.com/chainguard-dev/internal-dev/issues/9057) was closed last week after this PR was merged. Did that clear the path on this one, @OddBloke? |