-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k3s/1.32.0.1 package update #39284
k3s/1.32.0.1 package update #39284
Conversation
octo-sts
bot
commented
Jan 10, 2025
Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
The test is failing on the following command: strings $(which k3s) | grep -q "libseccomp" Previously, this command produced the following output:
Currently, we're setting ...
if [ -n "${DEBUG}" ]; then
GCFLAGS="-N -l"
else
LDFLAGS="-w -s"
fi
STATIC="
-extldflags '-static -lm -ldl -lz -lpthread'
"
TAGS="ctrd apparmor seccomp netcgo osusergo providerless urfave_cli_no_docs"
RUNC_TAGS="apparmor seccomp"
RUNC_STATIC="static"
if [ ${OS} = windows ]; then
TAGS="ctrd netcgo osusergo providerless"
fi
if [ "$SELINUX" = "true" ]; then
TAGS="$TAGS selinux"
RUNC_TAGS="$RUNC_TAGS selinux"
fi
if [ "$STATIC_BUILD" != "true" ]; then
STATIC="
"
RUNC_STATIC=""
else
TAGS="static_build libsqlite3 $TAGS"
fi
if [ -n "${GOCOVER}" ]; then
BLDFLAGS="-cover"
TAGS="cover $TAGS"
fi
mkdir -p bin
... |
Signed-off-by: Jason Hall <jason@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this bump didn't decouple libseccomp as a dependency, so simply checking the go build tags fixes the test, but we might just be able to remove the test entirely OR we're no longer building with libseccomp-static
checking this out now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright looks like the upstream binary no longer includes libseccomp, so I think these new tests are good and at least protect us from messing up the build flags!