fix the tests by adding java also remove the patches #38396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
octo-sts
bot
added
the
bincapz/pass
Aditvil-Dev
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, the test should have failed with non-zero code because I saw in the logs that there was a
java not founderror log, but somehow the tests passed even if the java command was not present.This caused another problem, when we applied the patch I saw other error logs like
java.lang.UnsupportedClassVersionError:org/eclipse/jetty/http/BadMessageException, but because the tests passed I didn't even realize that the project wasn't working as intended.So this PR aims to fix the issue but we should create an advisory for the CVE for sure.